Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add coverage for client._addHandle() #8518

Closed
wants to merge 2 commits into from
Closed

test: add coverage for client._addHandle() #8518

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 13, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test debugger

Description of change

Client.prototype._addHandle() in the _debugger module has conditions
around invalid properties that are not currently tested. This change
adds some minimal unit tests.

@Trott Trott added debugger test Issues and PRs related to the tests. labels Sep 13, 2016
@bnoordhuis
Copy link
Member

LGTM. s/covereage/coverage/ in the commit log.

@thefourtheye
Copy link
Contributor

Can you include some bad cases as well? Like NaN, 3.14, -1, Infinities, Zeroes...

@Trott
Copy link
Member Author

Trott commented Sep 13, 2016

Can you include some bad cases as well? Like NaN, 3.14, -1, Infinities, Zeroes...

Except for the last two, these are all bad cases. I can add more, I suppose.

@Trott
test: add coverage for client._addHandle()
29470f8 
`Client.prototype._addHandle()` in the `_debugger` module has conditions
around invalid properties that are not currently tested. This change
adds some minimal unit tests.
@Trott Trott changed the title test: add covereage for client._addHandle() test: add coverage for client._addHandle() Sep 13, 2016
@Trott
Copy link
Member Author

Trott commented Sep 13, 2016

@thefourtheye Of course, I go and add {handle: NaN} and immediately discover buggy behavior. :-|

@Trott
Copy link
Member Author

Trott commented Sep 13, 2016

@thefourtheye I'm inclined to not include those at this time because:

  • the resulting behavior is unexpected to me but...
  • ...it is not always clear to me that this is necessarily a bug and...
  • ...test coverage in the _debugger module is currently lacking.

So, I'd rather get these tests in as is. If we want to handle (for example) NaN, then that is a bugfix that (in my opinion) should be added separately so that (for one thing) if it needs to be reverted, we're not reverting all these other tests too.

At least, that's what I'm thinking at the moment. Does that work for you?

Good eye for the edge cases, gotta say.

@thefourtheye
Copy link
Contributor

Okay. We can discuss that in a separate PR. This LGTM.

@cjihrig
Copy link
Contributor

cjihrig commented Sep 14, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Sep 14, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4041/

jasnell
jasnell approved these changes Sep 15, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Sep 16, 2016
@Trott
test: add coverage for client._addHandle()
a01c365 
`Client.prototype._addHandle()` in the `_debugger` module has conditions
around invalid properties that are not currently tested. This change
adds some minimal unit tests.

PR-URL: nodejs#8518
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@Trott
Copy link
Member Author

Trott commented Sep 16, 2016

Landed in a01c365

@Trott Trott closed this Sep 16, 2016
MylesBorins pushed a commit that referenced this pull request Oct 6, 2016
@Trott
test: add coverage for client._addHandle()
f637f5a 
`Client.prototype._addHandle()` in the `_debugger` module has conditions
around invalid properties that are not currently tested. This change
adds some minimal unit tests.

PR-URL: #8518
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@Trott
test: add coverage for client._addHandle()
cc607b1 
`Client.prototype._addHandle()` in the `_debugger` module has conditions
around invalid properties that are not currently tested. This change
adds some minimal unit tests.

PR-URL: #8518
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@Trott @Fishrock123
test: add coverage for client._addHandle()
30e995f 
`Client.prototype._addHandle()` in the `_debugger` module has conditions
around invalid properties that are not currently tested. This change
adds some minimal unit tests.

PR-URL: #8518
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@Trott @rvagg
test: add coverage for client._addHandle()
39d96ab 
`Client.prototype._addHandle()` in the `_debugger` module has conditions
around invalid properties that are not currently tested. This change
adds some minimal unit tests.

PR-URL: #8518
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@Trott @MylesBorins
test: add coverage for client._addHandle()
9ffb2f3 
`Client.prototype._addHandle()` in the `_debugger` module has conditions
around invalid properties that are not currently tested. This change
adds some minimal unit tests.

PR-URL: #8518
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
@Trott Trott deleted the addhandle branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @bnoordhuis @thefourtheye @cjihrig @jasnell @MylesBorins